Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate nbytes for empty array correctly #10

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

andyferris
Copy link
Member

Previously it was assuming the byte header and and terminating 0 would be written for an empty array (for a total of 3 bytes instead of 1).

Fixes #9

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #10 (c42b4bc) into main (a95e23f) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   77.52%   77.83%   +0.31%     
==========================================
  Files          13       13              
  Lines         783      794      +11     
==========================================
+ Hits          607      618      +11     
  Misses        176      176              
Impacted Files Coverage Δ
src/types/arrays.jl 65.88% <100.00%> (+0.82%) ⬆️
src/types/records.jl 87.50% <0.00%> (+0.32%) ⬆️
src/types/binary.jl 85.71% <0.00%> (+0.32%) ⬆️
src/types/fixed.jl 84.00% <0.00%> (+0.66%) ⬆️
src/utils.jl 82.75% <0.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95e23f...c42b4bc. Read the comment docs.

@andyferris andyferris added the bug Something isn't working label Sep 14, 2021
@quinnj quinnj merged commit e523f8a into main Sep 14, 2021
@quinnj quinnj deleted the andyferris/empty-array-nbytes branch September 14, 2021 20:51
@quinnj
Copy link
Member

quinnj commented Sep 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error writing empty nested arrays
2 participants