Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Regex keys for selecting columns in types/dateformat/pool keyword #1016

Merged
merged 7 commits into from Sep 19, 2022
Merged

Allow Regex keys for selecting columns in types/dateformat/pool keyword #1016

merged 7 commits into from Sep 19, 2022

Conversation

nickrobinson251
Copy link
Collaborator

nickrobinson251
nickrobinson251 commented Jul 27, 2022
View reviewed changes
test/basics.jl Outdated Show resolved Hide resolved
@nickrobinson251
Copy link
Collaborator Author

let me know what you think (whenever you've time) @quinnj

if we like this i can add some docs (which should include this kind of stuff: #1014 (comment))

@nickrobinson251 nickrobinson251 mentioned this pull request Jul 28, 2022
Closed
quinnj
quinnj approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this looks great. Let's add some docs and merge away.

@nickrobinson251 nickrobinson251 merged commit ea78bbb into JuliaData:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Allow column selection for types with regex
2 participants
@nickrobinson251 @quinnj