Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SnoopPrecompile #1018

Merged
merged 1 commit into from Oct 7, 2022
Merged

Add SnoopPrecompile #1018

merged 1 commit into from Oct 7, 2022

Conversation

jakobnissen
Copy link
Contributor

On my computer, this reduces the time to first task by about 15-25%, depending
on the task at hand.

@quinnj I don't know the codebase, and so I'm not confident the workload I have in src/workload.jl is representative.
Using @snoopi_deep from SnoopCompile on CSV.read(path, DataFrame) reveals quite a lot of inference is still left, so it is likely possible that a workload file that exercises more functionality will lead to even better precompilation.

On my computer, this reduces the time to first task by about 15-25%, depending
on the task at hand.
@jakobnissen
Copy link
Contributor Author

Though see also #975 - if there is excessive type instability in this package, precompilation may not be a good idea.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is good. As mentioned, I think we have some additional cleanup to really get the most value out of this, but I think we merge this now and we can address other issues later.

@quinnj quinnj merged commit 77578cc into JuliaData:main Oct 7, 2022
quinnj added a commit that referenced this pull request Oct 22, 2022
quinnj added a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants