Fix case when type is provided for dropped columns #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional fix for #679. There was an alternative issue discovered in #679 where a type was given for a dropped column, like `CSV.File(file; types=Dict(:id=>Int32), select=["first"])`. During parsing, it knew we would drop the `id` column, so it parsed it as `Missing`, but then tried to "set" the value to a `Vector{Int32}` which threw an error. When dropping a column, we can basically ignore any provided type information instead, so in the `Header` routine, we make sure to mark the type of a column as `Missing` if it will be dropped.
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 84.16% 84.28% +0.11%
==========================================
Files 10 10
Lines 1800 1801 +1
==========================================
+ Hits 1515 1518 +3
+ Misses 285 283 -2
Continue to review full report at Codecov.
|
|
Thanks for this fix. As far as I can tell, it also fixes the issue in single-threaded mode, which makes your previous patch #683 unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix for #679. There was an alternative issue discovered in
#679 where a type was given for a dropped column, like
CSV.File(file; types=Dict(:id=>Int32), select=["first"]). During parsing, it knew wewould drop the
idcolumn, so it parsed it asMissing, but thentried to "set" the value to a
Vector{Int32}which threw an error.When dropping a column, we can basically ignore any provided type
information instead, so in the
Headerroutine, we make sure to markthe type of a column as
Missingif it will be dropped.