Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use depwarn for deprecations #704

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Use depwarn for deprecations #704

merged 1 commit into from
Aug 1, 2020

Conversation

omus
Copy link
Member

@omus omus commented Jul 31, 2020

Changes deprecation warnings to use Base.depwarn instead of @warn. The primary advantage is that you can use --depwarn=no to suppress deprecations or --depwarn=error to get a full stack trace.

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files          10       10           
  Lines        1847     1847           
=======================================
  Hits         1567     1567           
  Misses        280      280           
Impacted Files Coverage Δ
src/CSV.jl 25.00% <0.00%> (ø)
src/header.jl 95.00% <100.00%> (ø)
src/utils.jl 85.50% <100.00%> (ø)
src/write.jl 83.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0967a...7d61268. Read the comment docs.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@quinnj quinnj merged commit ab4ae50 into master Aug 1, 2020
@quinnj quinnj deleted the cv/use-actual-deprecations branch August 1, 2020 07:21
@tomyun
Copy link

tomyun commented Nov 19, 2020

I believe we should have used Base.depwarn(...; force=true) here, at least for some critical changes like CSV.read(). As most users running Julia under the default --depwarn=no, there has been a slim chance seeing these deprecation warnings beforehand.

@quinnj
Copy link
Member

quinnj commented Nov 20, 2020

Thanks for bringing this up @tomyun, I agree. I've made a PR to make a new 0.7 patch release to set force=true for the depwarns; this will allow packages on the 0.7 release to see the depwarns before updating. #782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants