Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical url to docs generator #717

Merged
merged 2 commits into from Aug 11, 2020

Conversation

IanButterworth
Copy link
Contributor

Partner to #715. Should sort out the future docs canonical links

@mortenpi
Copy link
Contributor

mortenpi commented Aug 9, 2020

LGTM. There were a few breaking changes in 0.24, but I think none of them affect this setup here.

Scratch that, there is a CI failure.

docs/make.jl Outdated Show resolved Hide resolved
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #717 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   84.81%   84.75%   -0.06%     
==========================================
  Files          10       10              
  Lines        1850     1850              
==========================================
- Hits         1569     1568       -1     
- Misses        281      282       +1     
Impacted Files Coverage Δ
src/file.jl 94.70% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93473f...6680e9b. Read the comment docs.

@quinnj
Copy link
Member

quinnj commented Aug 11, 2020

Thanks!

@quinnj quinnj merged commit e8e81f8 into JuliaData:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants