Warn if user passes threaded=true, but there aren't enough rows #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #723. The issue is that for threaded parsing, we need a minimum of 5 rows per task to correctly check that each threaded chunk starts at a proper row start position; if we don't have at least 5 rows per task, then we'll now issue a warning and set `threaded = false`.
bkamins
approved these changes
Aug 18, 2020
bkamins
reviewed
Aug 18, 2020
| @@ -526,6 +526,11 @@ f = CSV.File(transcode(GzipDecompressor, Mmap.mmap(joinpath(dir, "randoms.csv.gz | |||
| @test length(f) == 70000 | |||
| @test eltype(f.first) == String | |||
|
|
|||
| # 723 | |||
| f = CSV.File(IOBuffer("col1,col2,col3\n1.0,2.0,3.0\n1.0,2.0,3.0\n1.0,2.0,3.0\n1.0,2.0,3.0\n"); threaded=true) | |||
There was a problem hiding this comment.
do you have CI set up to use multiple threads?
There was a problem hiding this comment.
Yes; we start julia with 1 and 2 threads.
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 84.75% 84.78% +0.02%
==========================================
Files 10 10
Lines 1850 1853 +3
==========================================
+ Hits 1568 1571 +3
Misses 282 282
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #723. The issue is that for threaded parsing, we need a minimum of
5 rows per task to correctly check that each threaded chunk starts at a
proper row start position; if we don't have at least 5 rows per task,
then we'll now issue a warning and set
threaded = false.