Add lines_to_check to allow configuring multithreaded parsing #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #721. When multithreaded parsing, we have to split up a file and try to find the start of valid rows. By default, we've just been checking 5 rows to ensure we found the start of a valid row; this PR allows passing in a custom # of `lines_to_check` in case of problematic files, usually ones with very large quoted text fields.
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 10 10
Lines 1938 1938
=======================================
Hits 1663 1663
Misses 275 275
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721. When multithreaded parsing, we have to split up a file and
try to find the start of valid rows. By default, we've just been
checking 5 rows to ensure we found the start of a valid row; this PR
allows passing in a custom # of
lines_to_checkin case of problematicfiles, usually ones with very large quoted text fields.