Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we check for commented rows when skipping rows for header/data #789

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Ensure we check for commented rows when skipping rows for header/data #789

merged 5 commits into from
Nov 24, 2020

Commits on Nov 24, 2020

  1. Ensure we check for commented rows when skipping rows for header/data 

    Improves #788. In the original issue, a quote character on a commented
row messes the parsing positioning up because it's looking for a closing
quote character. By checking for and skipping commented rows, no matter
the characters present, we ensure parsing integrity. One ramification of
this, however, is that commented rows now "no longer count" when
considering row numbers, i.e. when specifying the `header=2` or
`datarow=4` keyword arguments, because the commented rows are literally
ignored when parsing. This seems fine to me, but probably warrants some
documentation so it's clear.
    @quinnj
    quinnj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    81cb617 View commit details
    Browse the repository at this point in the history

  2. Update docs and adjust tests

    @quinnj
    quinnj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    304baa7 View commit details
    Browse the repository at this point in the history

  3. Adjust fix

    @quinnj
    quinnj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    6bf67ab View commit details
    Browse the repository at this point in the history

  4. Update docs

    @quinnj
    quinnj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    72cc23e View commit details
    Browse the repository at this point in the history

  5. Add new tests from original issue

    @quinnj
    quinnj committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    7308bb3 View commit details
    Browse the repository at this point in the history