Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSV to support Parsers 2.0 #862

Merged
merged 3 commits into from
Aug 1, 2021
Merged

Update CSV to support Parsers 2.0 #862

merged 3 commits into from
Aug 1, 2021

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Jul 31, 2021

The motivation for the changes in Parsers.jl was to remove type parameters from Parsers.Options; this will enable CSV.jl to avoid needing to specialize on specific Parsers.Options when in hot parsing kernel loops. This should allow overall better initial latency when parsing, and certainly help avoid costly recompilation when different parsing options are passed.

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #862 (79b3dc4) into main (0eaacb4) will increase coverage by 0.65%.
The diff coverage is 96.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
+ Coverage   90.23%   90.88%   +0.65%     
==========================================
  Files           9        9              
  Lines        1874     1898      +24     
==========================================
+ Hits         1691     1725      +34     
+ Misses        183      173      -10     
Impacted Files Coverage Δ
src/CSV.jl 37.50% <ø> (ø)
src/detection.jl 96.65% <93.84%> (+0.76%) ⬆️
src/rows.jl 86.82% <96.00%> (-0.24%) ⬇️
src/file.jl 96.78% <97.54%> (+0.73%) ⬆️
src/utils.jl 83.40% <98.11%> (+1.90%) ⬆️
src/chunks.jl 91.30% <100.00%> (ø)
src/context.jl 87.86% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eaacb4...79b3dc4. Read the comment docs.

@quinnj quinnj merged commit 644076d into main Aug 1, 2021
@quinnj quinnj deleted the jq/parsers2 branch August 1, 2021 02:24
@ablaom
Copy link
Contributor

ablaom commented Aug 16, 2021

@quinnj Any chance of tagging a release to get this compat update?

@rikhuijzer
Copy link
Contributor

@quinnj I'm sorry to bump this, but I'm also running into this issue at TuringTutorials.jl and my blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants