Skip to content

Commit

Permalink
Avoid exporting normalize and graphemes
Browse files Browse the repository at this point in the history
These were not exported before being deprecated, and `normalize` can conflict with `LinearAlgebra.normalize`.
  • Loading branch information
nalimilan committed Dec 16, 2019
1 parent 4ad990c commit e6a41ba
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/deprecated.jl
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ import Unicode: normalize, graphemes

@deprecate isempty(x::CategoricalValue{String}) isempty(String(x))
@deprecate firstindex(x::CategoricalValue{String}) firstindex(String(x))
@deprecate normalize(x::CategoricalValue{String}, s::Symbol) normalize(String(x), s)
@deprecate normalize(x::CategoricalValue{String}; kwargs...) normalize(String(x); kwargs...)
@deprecate graphemes(x::CategoricalValue{String}) graphemes(String(x))
@deprecate normalize(x::CategoricalValue{String}, s::Symbol) normalize(String(x), s) false
@deprecate normalize(x::CategoricalValue{String}; kwargs...) normalize(String(x); kwargs...) false
@deprecate graphemes(x::CategoricalValue{String}) graphemes(String(x)) false
@deprecate length(x::CategoricalValue{String}, i::Int, j::Int) length(String(x), i, j)
@deprecate repeat(x::CategoricalValue{String}, i::Integer) repeat(String(x), i)
@deprecate eachmatch(r::Regex, x::CategoricalValue{String}; overlap=false) eachmatch(r, String(x), overlap=overlap)
Expand Down Expand Up @@ -124,4 +124,4 @@ import Unicode: normalize, graphemes
@deprecate findlast(needle::Function, haystack::CategoricalValue{String}) findlast(needle, String(haystack))
@deprecate findfirst(needle::Base.Fix2, haystack::CategoricalValue{String}) findfirst(needle, String(haystack))
@deprecate findlast(needle::Base.Fix2, haystack::CategoricalValue{String}) findlast(needle, String(haystack))
@deprecate replace(x::CategoricalValue{String}, old_new::Pair...; kwargs...) replace(String(x), old_new...; kwargs...)
@deprecate replace(x::CategoricalValue{String}, old_new::Pair...; kwargs...) replace(String(x), old_new...; kwargs...)

0 comments on commit e6a41ba

Please sign in to comment.