Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Depreciation #101

Merged
merged 2 commits into from Nov 19, 2017
Merged

Fix Depreciation #101

merged 2 commits into from Nov 19, 2017

Conversation

Nosferican
Copy link
Contributor

No description provided.

@nalimilan
Copy link
Member

Thanks, but that's not correct without using Compat (and bumping the requirement to the version that introduced that feature). The fact that tests passed indicates that this function isn't actually tested.

@Nosferican
Copy link
Contributor Author

Compat 23570. Going to leave the version here for later. Better wait until the function gets a test?

@nalimilan
Copy link
Member

Better fix it even if we don't have a test, though adding a test would be even better.

Earliest tag which contains the latest fix (Range -> AbstractRage).
@codecov
Copy link

codecov bot commented Nov 19, 2017

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files           9        9           
  Lines         673      673           
=======================================
  Hits          658      658           
  Misses         15       15
Impacted Files Coverage Δ
src/value.jl 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c57a2...d1c25d1. Read the comment docs.

@nalimilan
Copy link
Member

You also need to add using Compat somewhere, e.g. to src/CategoricalArrays.jl.

@Nosferican
Copy link
Contributor Author

I think the Require file had dropped Compat, but src/CategoricalArrays.jl still had it in line 14.

@nalimilan nalimilan merged commit 0efe75a into JuliaData:master Nov 19, 2017
@nalimilan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants