Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AbstractString methods for CategoricalString #198

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented Jun 7, 2019

This is the first step towards deprecating CategoricalString in favor of CategoricalValue{String}. (We can't just do that immediately since lots of string methods dispatch on AbstractString, from which CategoricalValue{String} cannot inherit.)

This is the first step towards deprecating CategoricalString in favor of
CategoricalValue{String}.
@bkamins
Copy link
Member

bkamins commented Jun 9, 2019

I am OK with this change.

What is your final opinion about adding levelcode and levelvalue as we discussed on Slack? (I ask because I see we use get here now)

@nalimilan
Copy link
Member Author

What is your final opinion about adding levelcode and levelvalue as we discussed on Slack? (I ask because I see we use get here now)

Yes, I think we should do that. I just wanted to make sure I like these names. :-)

@ablaom Do you have any opinion on merging CategoricalString and CategoricalValue{String}? I guess that would simplify the design a little bit for you, but I'd like to check that you don't rely on CategoricalString <: AbstractString.

@ablaom
Copy link

ablaom commented Jun 14, 2019

Thanks for consulting me. No, I don't rely on CategoricalString<:AbstractString and the proposed simplification makes sense to me.

@nalimilan nalimilan merged commit b59a0df into master Aug 4, 2019
@nalimilan nalimilan deleted the nl/strings branch August 4, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants