Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use levels from DataAPI #216

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Use levels from DataAPI #216

merged 2 commits into from
Oct 4, 2019

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented Oct 3, 2019 •
edited
Loading

@nalimilan
Use levels from DataAPI
eeef0b2 
Depends on JuliaData/DataAPI#12.
kleinschmidt
kleinschmidt requested changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@kleinschmidt kleinschmidt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to do using DataAPI: levels since that method is called too.

Actually, if you Missings re-exports it then that's fine, just need to have a release of Missings

@nalimilan nalimilan merged commit 451f37b into master Oct 4, 2019
@nalimilan nalimilan deleted the nl/levels branch October 4, 2019 11:57
@nalimilan
Copy link
Member Author

JuliaRegistries/General#4106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinschmidt kleinschmidt kleinschmidt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nalimilan @kleinschmidt