Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DataAPI.refarray/refpool #297

Closed
wants to merge 1 commit into from
Closed

Implement DataAPI.refarray/refpool #297

wants to merge 1 commit into from

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Sep 2, 2020

No description provided.

@bkamins
Copy link
Member

bkamins commented Sep 2, 2020

@nalimilan recently also mentioned implementing it. But if I remember correctly there was some issue with a correct handling of missings (do not remember the details now unfortunately)

@nalimilan
Copy link
Member

nalimilan commented Sep 2, 2020

Yeah, unfortunately that’s trickier because you need to handle missing values (ref 0). So we need to return an object which can be indexed with 0. I considered using CategoricalPool for that, but that requires making it aware of whether its parent array allows for missing values (via a type parameter).

@nalimilan
Copy link
Member

See #303.

@nalimilan nalimilan closed this Sep 17, 2020
@nalimilan nalimilan deleted the jq/dataapi branch September 17, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants