droplevels!(): more efficient implementation #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
approved these changes
Jul 7, 2021
nalimilan
approved these changes
Jul 9, 2021
nalimilan
reviewed
Jul 9, 2021
bkamins
reviewed
Jul 10, 2021
nalimilan
approved these changes
Jul 10, 2021
bkamins
reviewed
Jul 11, 2021
|
do you think it is ready to be merged? |
|
We might need to wait a bit as @nalimilan is OOO AFAICT. |
|
gentle bump |
|
Feel free to merge PRs that I have approved (three times!). :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the current one-line implementation of
droplevels!()as behind the scenes it requires sorting and arrays intersection.The new implementation scans the array only once, and doesn't rebuild the array when all levels are observed.