Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardized return values for groupby #1554

Closed
ExpandingMan opened this issue Oct 3, 2018 · 3 comments
Closed

standardized return values for groupby #1554

ExpandingMan opened this issue Oct 3, 2018 · 3 comments
Labels

Comments

@ExpandingMan
Copy link
Contributor

I seem to recall that at some point we had discussed and agreed that

by(identity, df, cols)

where cols is any subset of names(df) should return df up to an ordering ambiguity.

Currently this is not the case since the key columns are appended after the group by operation.

Do we indeed agree that this should change? Would you accept a PR?

I seem to recall that pandas does what I'm suggesting, but I don't remember for sure and haven't checked.

@nalimilan
Copy link
Member

See also #1460. I don't think we should omit the key columns by default, as they are needed most of the time (I would say). Can you check what Pandas does? But adding an argument is OK.

@bkamins bkamins mentioned this issue Jan 15, 2019
31 tasks
@bkamins
Copy link
Member

bkamins commented Sep 2, 2019

I would say that resolving this issue is crucial before we move to 1.0 release in the "by world".

@nalimilan - do you have a recommendation what we should do with "duplicate columns" produced by adding key columns by default?

@nalimilan
Copy link
Member

My latest thoughts are at #1460 (comment). Let's close this in favor of the other issue. I've filed #1938 to implement the proposed solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants