Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the behavior of push!, vcat and append! in DataFrames.jl with Base #1904

Closed
bkamins opened this issue Jul 28, 2019 · 4 comments · Fixed by #1958
Closed

Sync the behavior of push!, vcat and append! in DataFrames.jl with Base #1904

bkamins opened this issue Jul 28, 2019 · 4 comments · Fixed by #1958
Assignees

Comments

@bkamins
Copy link
Member

bkamins commented Jul 28, 2019

When the decision in JuliaLang/julia#25904 is made I think we should use consistent rules by default (and optionally have a keyword argument to add/reduce flexibility - depending if JuliaLang/julia#25904 will end up being flexible or strict).

@bkamins
Copy link
Member Author

bkamins commented Aug 13, 2019

@nalimilan - actually looking at the current API the only change I would make is to add :identical option for cols kwarg, that is even stricter than :equal and requires not only that the names match but that they must be in the same order. Then we could, in the future change vcat to default to :identical instead of current :equal.

@nalimilan
Copy link
Member

Why not. Names aren't very descriptive but it's hard to find better ideas.

@bkamins
Copy link
Member Author

bkamins commented Aug 20, 2019

Yes - I had a problem with :equal as it is already in use, but I could not come up with anything better.

@nalimilan
Copy link
Member

We could deprecate :equal if we can find a better name...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants