Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop master branch? #3121

Closed
PallHaraldsson opened this issue Aug 22, 2022 · 6 comments
Closed

Drop master branch? #3121

PallHaraldsson opened this issue Aug 22, 2022 · 6 comments
Labels
ecosystem Issues in DataFrames.jl ecosystem

Comments

@PallHaraldsson
Copy link

This worked:

(@v1.9) pkg> add DataFrames#main

but out of habit, while debugging a problem I did, and scratch my head why (despite Compat entry no wrong):

(@v1.9) pkg> add DataFrames#master
     Cloning git-repo `https://github.com/JuliaData/DataFrames.jl.git`
    Updating git-repo `https://github.com/JuliaData/DataFrames.jl.git`
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package Compat [34da2185]:
 Compat [34da2185] log:
 ├─possible versions are: 4.2.0 or uninstalled
 ├─restricted to versions 3.17.0-3 by DataFrames [a93c6f00] — no versions left
 │ └─DataFrames [a93c6f00] log:
 │   ├─possible versions are: 0.22.1 or uninstalled
 │   └─DataFrames [a93c6f00] is fixed to version 0.22.1
 └─Compat [34da2185] is fixed to version 4.2.0
@bkamins
Copy link
Member

bkamins commented Aug 22, 2022

It was discussed, and the decision was to keep it as there was no harm of keeping it (in particular it is not installable any more). But I would be OK to delete master. @nalimilan - any opinion?

@bkamins bkamins added the ecosystem Issues in DataFrames.jl ecosystem label Aug 22, 2022
@PallHaraldsson
Copy link
Author

PallHaraldsson commented Aug 23, 2022

I can see you wanted to keep it (maybe) at the time, but it's 2+ years old by now, so what would be the point of keeping it? At some point I thought "master" was some magic in git, but it's just another branch(?) and I see branches being deleted all the time.

I .e. I think it could be ok, and by now just a footgun.

@nalimilan
Copy link
Member

I also get confused at times when I do git checkout master. I guess it would be OK to remove it now.

@bkamins
Copy link
Member

bkamins commented Aug 24, 2022

OK. So let us remove it. @nalimilan - first you need to change target of your PR #2491 (or close it) and then master can be deleted. Can you please do it? (I do not want to mess with your PR)

@nalimilan
Copy link
Member

OK, changed.

@bkamins
Copy link
Member

bkamins commented Aug 25, 2022

Thank you. I have removed master.

@bkamins bkamins closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Development

No branches or pull requests

3 participants