Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show problem columns for "ArgumentError: missing values in key columns are not allowed when matchmissing == :error" #3345

Closed
jariji opened this issue Jun 24, 2023 · 5 comments · Fixed by #3349
Labels
Milestone

Comments

@jariji
Copy link
Contributor

jariji commented Jun 24, 2023

When this error comes up

ArgumentError: missing values in key columns are not allowed when matchmissing == :error

it would be helpful to report which columns (in which tables) are the problem.

@bkamins bkamins added this to the 1.6 milestone Jun 25, 2023
@bkamins
Copy link
Member

bkamins commented Jun 25, 2023

OK. How would you refer to the tables? (the issue is innerjoin/outerjoin which allow for passing multiple tables, but maybe saying left/right table is enough to cover most common cases?)

@jariji
Copy link
Contributor Author

jariji commented Jun 25, 2023

"In DataFrame 2, column foo"

@bkamins
Copy link
Member

bkamins commented Jun 26, 2023

In #3349 I proposed to use left/right data frame terminology.

@jariji
Copy link
Contributor Author

jariji commented Jun 26, 2023

That's probably best for two-argument cases. If the problem is in the third of 4, I'd rather it say DataFrame 3 than "the right DataFrame".

@bkamins
Copy link
Member

bkamins commented Jun 26, 2023

I know, but:

  1. The good thing is that "left" essentially means 1st, and "right" means 2nd or later, so the message is correct.
  2. The implementation of a multi-argument case is recursive, and we would need to redesign the implementation to handle it. I was not sure it was worth doing it (as probably in practice 2-argument case is most common).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants