-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add row-wise macros #267
Merged
Merged
Add row-wise macros #267
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
19fd4f7
add rtransform
pdeffebach e58990b
add transform!
pdeffebach 0b2396a
add select
pdeffebach 18f5373
add subset!
pdeffebach 32465b1
orderby
pdeffebach 6a0bc98
update exports
pdeffebach 297379a
rorderby
pdeffebach c1c8b16
start adding tests
pdeffebach 7520852
finish adding tests
pdeffebach 7a5bd1b
update docstrings
pdeffebach c8fe5d5
Apply suggestions from code review
pdeffebach 5a0de92
put byrow check in the function
pdeffebach 0ed540b
whitespace changes
pdeffebach 6359b86
update docstrings
pdeffebach 66d8c9d
Apply suggestions from code review
pdeffebach e5bf82f
Merge remote-tracking branch 'origin/master' into rtransform
pdeffebach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would there be a way to avoid duplicating these helper functions, for example by passing
subset
orsubset!
to a more generic one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that't what DataFrameMacros does. I will do this in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not do it now? :-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I've simplified the
@byrow
check but it's hard to actually make everything in a coherent functiont = (fun_to_vec(ex; no_dest=true, outer_flags=outer_flags) for ex in exprs)
can't be gotten rid of yet because we still need to support some deprecated functionality in@combine
.@subset
requires a keyword argument,@orderby
doesn't even call a DataFrames function. Writing a function for these cases would be just as easy as writing out the expression.