Add a @passmissing flag, only with @byrow for now.
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
reviewed
Jul 31, 2021
bkamins
reviewed
Jul 31, 2021
bkamins
reviewed
Jul 31, 2021
bkamins
reviewed
Jul 31, 2021
|
Also index.md needs an update I think (as it currently mentions |
pdeffebach
commented
Jul 31, 2021
There was a problem hiding this comment.
Thanks! @bkamins I just pushed the index.md stuff as well.
So all the moving parts are done and if it looks good it can be merged.
bkamins
reviewed
Jul 31, 2021
docs/src/index.md
Outdated
| @@ -21,6 +21,7 @@ In addition, DataFramesMeta provides | |||
| * `@eachrow` and `@eachrow!` for looping through rows in data frame, again with high performance and | |||
| convenient syntax. | |||
| * `@byrow` for applying functions to each row of a data frame (only supported inside other macros). | |||
| * `@passmissing` for propagating missing values inside DataFramesMeta.jl transformations. | |||
There was a problem hiding this comment.
in line 6: DataFramesMeta.jl (I cannot correct it in the editor)
bkamins
reviewed
Jul 31, 2021
docs/src/index.md
Outdated
| @@ -21,6 +21,7 @@ In addition, DataFramesMeta provides | |||
| * `@eachrow` and `@eachrow!` for looping through rows in data frame, again with high performance and | |||
| convenient syntax. | |||
| * `@byrow` for applying functions to each row of a data frame (only supported inside other macros). | |||
| * `@passmissing` for propagating missing values inside DataFramesMeta.jl transformations. | |||
bkamins
reviewed
Jul 31, 2021
docs/src/index.md
Outdated
| Missings.jl provides the `passmissing` function-wrapper to help get around these | ||
| roadblocks: `passmissing(f)(args...)` will return `missing` if any of `args` is | ||
| missing. Similarly, DataFramesMeta.jl provides the `@passmissing` function to wrap | ||
| the anonymous functions created by DataFramesMeta.jl in `Missings.passmissing`. |
bkamins
reviewed
Jul 31, 2021
| function check_macro_flags_consistency(exprflags) | ||
| if exprflags[PASSMISSING_SYM][] | ||
| if !exprflags[BYROW_SYM][] | ||
| s = "The `@passmissing` flag is currently only allowed with the `@byrow` flag" |
bkamins
reviewed
Jul 31, 2021
| fun = :(ByRow($fun)) | ||
| if exprflags[BYROW_SYM][] | ||
| if exprflags[PASSMISSING_SYM][] | ||
| fun = :(ByRow(Missings.passmissing($fun))) |
There was a problem hiding this comment.
looks good performance wise :).
bkamins
approved these changes
Jul 31, 2021
Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.