Write up rules regarding multi-column indexing #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
reviewed
Aug 8, 2021
bkamins
reviewed
Aug 8, 2021
bkamins
reviewed
Aug 8, 2021
bkamins
reviewed
Aug 8, 2021
bkamins
reviewed
Aug 8, 2021
|
Thank you very much for the write up. This was my experience from DataFrames.jl that things are usually more complex than they initially apperar. |
|
@pdeffebach: Regarding your last two comments I think you have not pushed the changes to GitHub. Right? |
pdeffebach
commented
Aug 10, 2021
|
Sorry about that. Updated now. |
bkamins
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You were correct, @bkamins , the rules are more complicated than I initially realized. So much that it's hard to put them all in a bulleted list.
I think I have a good idea of the gaps and marked the appropriate places as unstable, and we can iteratively improve the code so the rules are clear and consistent.