Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping $ #285

Merged
merged 2 commits into from Aug 10, 2021
Merged

Fix escaping $ #285

merged 2 commits into from Aug 10, 2021

Conversation

pdeffebach
Copy link
Collaborator

Rules:

Inside .md files, you can use $ however much you want.

Inside docstrings, we have the global variable const DOLLAR = raw"$". We interpolate $DOLLAR everywhere we want a raw $, which is ironic.

@pdeffebach
Copy link
Collaborator Author

@bkamins PR is ready for a review. I built the docs and things look good.

src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have made two small suggestions.

Co-authored-by: Bogumił Kamiński <bkamins@sgh.waw.pl>
@pdeffebach pdeffebach merged commit 3b45404 into JuliaData:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants