Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition of nested functions #319

Merged
merged 7 commits into from
Jan 6, 2022
Merged

Conversation

pdeffebach
Copy link
Collaborator

This PR performs the following transformation

julia> DataFramesMeta.@col :y = first(last(:x))
[:x] => (first ∘ last => :y)

Tests are added and pass. I only need to fix one issue with macro hygiene, in case someone overloads .

@pdeffebach
Copy link
Collaborator Author

pdeffebach commented Jan 5, 2022

I have fixed the macro hygiene issue with help from Slack. This is ready for a review. Test failures seem unrelated.

src/parsing.jl Outdated Show resolved Hide resolved
@pdeffebach
Copy link
Collaborator Author

This should be ready for a review from @nalimilan

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Just a few minor things.

src/parsing.jl Outdated Show resolved Hide resolved
src/parsing.jl Outdated Show resolved Hide resolved
src/parsing.jl Outdated Show resolved Hide resolved
src/parsing.jl Outdated Show resolved Hide resolved
src/parsing.jl Outdated Show resolved Hide resolved
src/parsing.jl Outdated Show resolved Hide resolved
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@pdeffebach
Copy link
Collaborator Author

Thanks! Will merge.

@pdeffebach pdeffebach merged commit 41a6e29 into JuliaData:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants