Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project.toml #332

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Update Project.toml #332

merged 2 commits into from
Jul 6, 2022

Conversation

zsz00
Copy link
Contributor

@zsz00 zsz00 commented Jul 3, 2022

No description provided.

@pdeffebach
Copy link
Collaborator

Thanks!

I think we need to update to 0.12.0 for this. @nalimilan do you agree? With this new version of Chain.jl, you can do the following.

@chain df begin 
    @aside x = 1
end
x # assigned inside block

So if we go to 0.11.1 (a very minor inrement), people might write code like the above which works, but then a downgrade will break it.

@nalimilan
Copy link
Member

Indeed, as Chain is reexported then allowing a new version which is breaking requires tagging a breaking version of DataFramesMeta too. Better disallow 0.4 too, otherwise users can silently get a different API just because Chain changes version.

@pdeffebach
Copy link
Collaborator

Thanks! @zsz00 can you make these changes?

@zsz00
Copy link
Contributor Author

zsz00 commented Jul 5, 2022

change to :

version = "0.12.0"
[compat]
Chain = "0.5"

??
@pdeffebach

@pdeffebach
Copy link
Collaborator

yes please.

@zsz00
Copy link
Contributor Author

zsz00 commented Jul 6, 2022

Done

@pdeffebach pdeffebach merged commit cd82545 into JuliaData:master Jul 6, 2022
@zsz00
Copy link
Contributor Author

zsz00 commented Jul 9, 2022

can you realse a 0.12.0 ?

@pdeffebach
Copy link
Collaborator

Released! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants