Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrames 0.11 support #79

Merged
merged 2 commits into from
Nov 29, 2017
Merged

DataFrames 0.11 support #79

merged 2 commits into from
Nov 29, 2017

Conversation

nalimilan
Copy link
Member

Also drop support for Julia 0.5 and NullableArrays.

Also drop support for Julia 0.5 and NullableArrays.
@nalimilan
Copy link
Member Author

I don't understand why tests fail, as they pass locally on 0.6. Ideas?

@ararslan
Copy link
Member

Wow, excellent failure message: ERROR: LoadError: "Tests failed". A+

@tshort
Copy link
Contributor

tshort commented Nov 29, 2017

I like! I like! I love the way DataFrames now supports more vector types, including Vector.

The crappy error message for failed tests is my fault. I can't imagine why I did it that way.

I'll see if I can reproduce test failures locally (but no guarantees as all I've got is a windows laptop on travel).

@tshort
Copy link
Contributor

tshort commented Nov 29, 2017

I think test/REQUIRE needs DataArrays added.

@nalimilan
Copy link
Member Author

Cool, thanks! Tests pass on 0.6 now.

The best solution will be to move to testsets eventually.

@tshort tshort merged commit 4f727e1 into master Nov 29, 2017
@ararslan ararslan deleted the nl/dataframes0.11 branch November 29, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants