This repository has been archived by the owner on May 5, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Stop auto-promoting column-types #30
Closed
Closed
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
8db2821
add changes
cjprybol 4a939fe
make vcat error more informative
cjprybol f5a53a1
add docstring for vcat
cjprybol 2c95f13
incorporate edits suggested during review
cjprybol 412ceaa
_unsafe_get -> NullableArrays.unsafe_get
cjprybol f142df5
Merge branch 'master' into cjp/rebaseretaintype
cjprybol cc95658
fix new tests from master
cjprybol 06dc914
remove RepeatedVector, StackedVector, unstackdt, meltdt
cjprybol c4e218e
DataFrames doensn't reshape 2d Arrays -> Vectors so don't do it here
cjprybol e954226
minor cleanup
cjprybol ed8a515
change (de)nullify back to copy and cleanup docstrings
cjprybol 1636a0c
NullableArrays.unsafe_get -> compat(unsafe_get)
cjprybol 91233d3
default to NullableArray for joins that may introduce missing data
cjprybol 7462612
align comments
cjprybol 9b65533
lots of edits
cjprybol b643ff8
tests and no need for compat
cjprybol 4c68452
spacing mistakes
cjprybol 7310681
throw errors on 1-d matrices and change confusing variable name
cjprybol de280ba
add back check to differentiate scalars from AbstractArrays
cjprybol 88b20ca
save work
cjprybol be1cacd
save progress, switch to test master
cjprybol 19ffb58
join is ready and tests in place. right join still broken
cjprybol 3f2cd63
fix right join
cjprybol 9c3ad21
update join help message and add note about temp fix
cjprybol 1e7d26e
indentation
cjprybol e39ba63
changes
cjprybol 04cb9ee
spacing
cjprybol 5d70685
put old unstack back and stabilize types, ordering
cjprybol 7859132
fix bad copy and paste spacing and condense scalar recycling code
cjprybol 6496acf
update vcat error
cjprybol f47810f
unused function, another test, remove unused variable
cjprybol 259ceef
revert function removal to appease new code failures?
cjprybol 26e87ac
fix v0.5 issue
cjprybol e0f7982
update vcat testing and change similar_nullable constructor call
cjprybol d65385e
:Merge branch 'cjp/retaintype' of github.com:cjprybol/DataTables.jl i…
cjprybol b0c29b4
remove old error message from docstring
cjprybol 95a6f31
and change docstring to doctest
cjprybol 7df712f
change similar_nullable back and fix unrelated copy paste space removal
cjprybol 27da644
add missing rightperm reordering and properly unify hcat! functions
cjprybol 5fa8fa0
accidental spacing changes
cjprybol a1d58f9
forgot one spacing change
cjprybol db87443
change deprecations
cjprybol 9c66a1e
add back extra spaces
cjprybol 887346b
bump catarrays version, remove manual resetting of levels in unstack
cjprybol 00c08cc
Merge branch 'master' into cjp/retaintype
cjprybol 020c88e
only use "and" when joining the last estring
cjprybol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do
NullableArray
s not support the proper type parameter convention? I thought that was justDataArray
s.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, they do. This is reverting back to the current master syntax. Now that I've added tests for CategoricalArrays in unstack (or maybe just ran a Pkg.update?) I caught a new deprecation warning.
I changed all of these to the new syntax but @nalimilan asked if I would revert and save the changes for another PR, too many changes at once.