This repository has been archived by the owner on May 5, 2019. It is now read-only.
consolidate internal hcat! function and remove autopromotion #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Apr 1, 2017
| hcat!(dt::DataTable, x::CategoricalArray) = hcat!(dt, DataTable(Any[x])) | ||
| hcat!(dt::DataTable, x::NullableCategoricalArray) = hcat!(dt, DataTable(Any[x])) | ||
| hcat!(dt::DataTable, x::NullableVector) = hcat!(dt, DataTable(Any[x])) | ||
| hcat!(dt::DataTable, x::Vector) = hcat!(dt, DataTable(Any[NullableArray(x)])) |
There was a problem hiding this comment.
AFAICT this stops autopromotion to NullableArray? It's surprising that the tests didn't need adjustment. Please mention this in the commit message.
All tests passed without needing any changes. Also removes an unneccessary empty line.
|
commit message updated, and tests still green! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was part of #30