This repository has been archived by the owner on May 5, 2019. It is now read-only.
Update CSV examples to reflect that DataFrames is default CSV sink #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Apr 15, 2017
docs/src/man/getting_started.md
Outdated
| ``` | ||
|
|
||
| and written using | ||
| note the second argument of `DataTable`, which instructs the CSV package to output a |
docs/src/man/getting_started.md
Outdated
| @@ -159,14 +159,18 @@ using CSV | |||
| using DataTables, CSV | |||
| ``` | |||
|
|
|||
| Datasets can now be read using | |||
| Datasets can now be read from input sources using | |||
There was a problem hiding this comment.
"input sources" is quite vague. Since this section talks about files, better say "files" instead to keep things simple. Reading from streams is a more advanced use case, which could be mentioned as a bonus.
docs/src/man/getting_started.md
Outdated
| ```julia | ||
| CSV.read(...) | ||
| CSV.read(input, DataTable, args...) |
There was a problem hiding this comment.
args isn't defined. I would just put the two first arguments, and say in the text that more optional arguments can be passed.
|
Updated as suggested, thanks Milan! |
nalimilan
reviewed
Apr 16, 2017
docs/src/man/getting_started.md
Outdated
| ```julia | ||
| CSV.read(...) | ||
| CSV.read(input, DataTable) |
There was a problem hiding this comment.
input is still not defined. I would add something to the previous paragraph, like "A dataset can now be read from a CSV file at path input using". Same for output.
Current examples assume DataTable is the default sink.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current examples assume DataTable is the default sink. JuliaData/CSV.jl#73