This repository has been archived by the owner on May 5, 2019. It is now read-only.
Extend nullable! code, fix NullableArray hardcoding #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
May 25, 2017
src/datatable/datatable.jl
Outdated
| @@ -758,6 +758,30 @@ function nullable!{T <: ColumnIndex}(dt::DataTable, cols::Vector{T}) | |||
| end | |||
| dt | |||
| end | |||
| function nullable!(dt::DataTable) | |||
There was a problem hiding this comment.
Even if that only saves a few lines, this can be replaced with cols::Vector{T}=names(dt) in the previous definition.
Adds nullable versions of nullable! for copies rather than inplace. Adds tests to check proper handling of CategoricalArrays. Adds a similar_nullable function that will use the size of the Array rather than always requiring the user to pass the size as an argument. Converts a nullable! call that operated over the entire datatable to use a new nullable! func that operates over all columns.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds nullable versions of nullable! for copies rather than inplace.
Adds tests to check proper handling of CategoricalArrays. Adds a
similar_nullable function that will check the size of the Array.
Converts a nullable! call that operated over the entire datatable
to use a new nullable! func that operates over all columns.
This should help with #66 (comment)