This repository has been archived by the owner on May 5, 2019. It is now read-only.
Extend StatsBase.describe to handle Nulls #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
May 24, 2017
test/utils.jl
Outdated
| Number Missing: 3 | ||
| % Missing: 100.000000 | ||
| """ | ||
| describe(io, Vector{?Int}(1:3)) |
There was a problem hiding this comment.
This last one shouldn't be necessary, right?
ararslan
reviewed
May 24, 2017
| @@ -378,6 +378,32 @@ function StatsBase.describe(io, dt::AbstractDataTable) | |||
| println(io, ) | |||
| end | |||
| end | |||
| function StatsBase.describe{T <: Real}(io::IO, X::Vector{Union{T, Null}}) | |||
| nullcount = sum(isnull, X) | |||
There was a problem hiding this comment.
I usually prefer count for this sort of thing, but sum is equivalent so it doesn't really matter
nalimilan
reviewed
May 25, 2017
test/utils.jl
Outdated
| 3rd Quartile: 2.500000 | ||
| Maximum: 3.000000 | ||
| Length: 3 | ||
| Type: Int64 |
|
This will fix: #60 |
|
#60 is already fixed on DataTables master. |
This was referenced Aug 2, 2017
|
superseded by #83 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For merging into #66