This repository has been archived by the owner on May 5, 2019. It is now read-only.
Add upper limit on DataStreams and WeakRefStrings version #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
Aug 25, 2017
cjprybol
approved these changes
Aug 25, 2017
|
|
|
The DataStreams upper bound should already include the WRS bound, so not technically, but couldn't hurt. |
Next major releases of DataStreams and WeakRefStrings will move from
`Nullable` to `Union{T, Null}` and will not work with the package
in its current state.
nalimilan
force-pushed
the
nl/datastreams
branch
from
7172ab8
to
1b0113e
Compare
|
I've also added the upper bound for WeakRefStrings, can't hurt. |
nalimilan
changed the title
|
Failing on nightlies due to an issue in CSV https://ci.appveyor.com/project/nalimilan/datatables-jl/build/1.0.379/job/ddcpq7vwdvg5dwdd#L4871. I've tagged a new release which should include the fix JuliaLang/METADATA.jl#10923 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next major releases of DataStreams and WeakRefStrings will move from
NullabletoUnion{T, Null}and will not work with the package in its current state.Cf. JuliaLang/METADATA.jl#10915.