poolset: Call GC when free mem is low #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
force-pushed
the
jps/memory-bloat
branch
2 times, most recently
from
5e44c20
to
7a41006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to work around memory usage issues in a similar manner to the Julia GPU packages: when
poolsetis called, if we're running low on memory (according to a configurable threshold), then we do increasingly expensive calls to the GC to try to free up enough memory to avoid an OOM.An enhancement that we could make is to keep trying to GC until we don't free any memory. To be investigated.
@StevenWhitaker @svilupp this might help with the OOM issues seen with your workloads.
@krynju I'm considering enabling this by default, do you have any objections to that?