Support one and oneunit #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
approved these changes
Nov 29, 2017
nalimilan
reviewed
Nov 29, 2017
| @@ -95,8 +95,9 @@ for f in (:(!), :(+), :(-), :(Base.identity), :(Base.zero), | |||
| @eval $(f)(d::Missing) = missing | |||
| end | |||
|
|
|||
| Base.zero(::Type{Union{T, Missing}}) where {T <: Number} = zero(T) | |||
There was a problem hiding this comment.
Thanks for pointing this out. I think I found a nice way to work around the type piracy problem.
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 94.03% 94.07% +0.03%
==========================================
Files 1 1
Lines 151 152 +1
==========================================
+ Hits 142 143 +1
Misses 9 9
Continue to review full report at Codecov.
|
cjprybol
approved these changes
Nov 30, 2017
nalimilan
approved these changes
Nov 30, 2017
Will update JuliaLang/julia#24653 |
|
I believe this is ready to merge. Any other comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.