remove unbound type parameters #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't check, but unbound type parameters often cause performance issues, so this may not be merely cosmetic. FTR, there's a relevant function in Test in stdlib for checking this stuff: https://docs.julialang.org/en/v1/stdlib/Test/#Test.detect_unbound_args
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 86.21% 86.25% +0.04%
==========================================
Files 9 9
Lines 2350 2350
==========================================
+ Hits 2026 2027 +1
+ Misses 324 323 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't check, but unbound type parameters often cause performance issues, so this may not be merely cosmetic.
FTR, there's a relevant function in Test in stdlib for checking this stuff:
https://docs.julialang.org/en/v1/stdlib/Test/#Test.detect_unbound_args