Use Aqua and JET in tests #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drvi
force-pushed
the
td-aqua-jet-linting
branch
from
043c905
to
ff15e3d
Compare
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 86.21% 89.71% +3.50%
==========================================
Files 9 9
Lines 2350 2440 +90
==========================================
+ Hits 2026 2189 +163
+ Misses 324 251 -73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Drvi
force-pushed
the
td-aqua-jet-linting
branch
from
ff15e3d
to
199dba6
Compare
|
Hmm, can't reproduce the JET failures locally. Will try on a linux machine. UPDATE: No change :/ |
Drvi
force-pushed
the
td-aqua-jet-linting
branch
from
199dba6
to
aa6b0f9
Compare
quinnj
approved these changes
Sep 13, 2022
|
The nightly JET failures are being tracked here |
nickrobinson251
added a commit
that referenced
this pull request
Oct 12, 2022
This reverts commit 6297d57.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Aqua, this PR automates checking for method ambiguities, unbound type parameters, undefined exports, and compat bounds being set.
Using JET to make sure
xparsedoesn't have dynamic dispatch or boxed variables in closures. There seem to be code paths leading to dynamic dispatch when parsingDateandTimetypes.