Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable precompilation for common Parsers routines #148

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Nov 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 90.99% // Head: 91.10% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (f33c011) compared to base (5c94282).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   90.99%   91.10%   +0.10%     
==========================================
  Files           9        9              
  Lines        1611     1607       -4     
==========================================
- Hits         1466     1464       -2     
+ Misses        145      143       -2     
Impacted Files Coverage Δ
src/precompile.jl 100.00% <100.00%> (+50.00%) ⬆️
src/ints.jl 89.70% <0.00%> (-1.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quinnj
Copy link
Member Author

quinnj commented Nov 4, 2022

Ok, I've confirmed that on a windows machine w/ 1.8.2, I can successfully run the Parsers tests, all CSV tests (on this branch, and read the file in JuliaData/CSV.jl#1041 w/o crashing. So I say let's go for this and see if anything pops up this time around.

@quinnj quinnj merged commit 38615bb into main Nov 4, 2022
@quinnj quinnj deleted the jq/precompile branch November 4, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant