Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equality definition between byte and Token #151

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Fix equality definition between byte and Token #151

merged 2 commits into from
Nov 15, 2022

Conversation

nickrobinson251
Copy link
Collaborator

@nickrobinson251 nickrobinson251 commented Nov 15, 2022 •
edited
Loading

ablaom
ablaom approved these changes Nov 15, 2022
View reviewed changes
Copy link

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nickrobinson251 nickrobinson251 merged commit f994915 into main Nov 15, 2022
@nickrobinson251 nickrobinson251 deleted the npr/150-token-uint8-eq branch November 15, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drvi Drvi Drvi approved these changes

@ablaom ablaom ablaom approved these changes

@quinnj quinnj Awaiting requested review from quinnj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsers.jl version 2.5 appears to break OpenML.jl
3 participants
@nickrobinson251 @Drvi @ablaom