Ensure Char doesn't match provided delim before marking OK #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the switch to making Char non-greedy in the 2.5 release, I failed to account for the fact that the parsed Char may in fact be the delimiter provided, in which case we want to match the delim instead of treating it as a successfully parsed Char (Char is greedy in this way like Strings). Luckily we can still do this pretty efficiently by checking our parsed Char against the delimiter, if there is one.
Codecov ReportBase: 91.03% // Head: 88.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 91.03% 88.36% -2.68%
==========================================
Files 9 8 -1
Lines 1607 1530 -77
==========================================
- Hits 1463 1352 -111
- Misses 144 178 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I think the interaction with EOF is still not quite right, compared to String, for example: julia> Parsers.xparse(String, ",,", 1, 2, Parsers.Options(sentinel=missing, delim=','))
Parsers.Result{Parsers.PosLen}(code=`SUCCESS: SENTINEL | DELIMITED `, tlen=1, val=PosLen(pos=1, len=0, missingvalue=false, escapedvalue=false))
julia> Parsers.xparse(String, ",,", 2, 2, Parsers.Options(sentinel=missing, delim=','))
Parsers.Result{Parsers.PosLen}(code=`SUCCESS: SENTINEL | DELIMITED `, tlen=1, val=PosLen(pos=2, len=0, missingvalue=false, escapedvalue=false))
julia> Parsers.xparse(String, ",,", 3, 2, Parsers.Options(sentinel=missing, delim=','))
Parsers.Result{Parsers.PosLen}(code=`SUCCESS: SENTINEL | EOF `, tlen=0, val=PosLen(pos=3, len=0, missingvalue=false, escapedvalue=false))julia> Parsers.xparse(Char, ",,", 1, 2, Parsers.Options(sentinel=missing, delim=','))
Parsers.Result{Char}(code=`SUCCESS: SENTINEL | DELIMITED `, tlen=1, val=����)
julia> Parsers.xparse(Char, ",,", 2, 2, Parsers.Options(sentinel=missing, delim=','))
Parsers.Result{Char}(code=`SUCCESS: SENTINEL | DELIMITED | EOF `, tlen=1, val=����)
julia> Parsers.xparse(Char, ",,", 3, 2, Parsers.Options(sentinel=missing, delim=','))
Parsers.Result{Char}(code=`SUCCESS: OK | EOF `, tlen=1, val=) |
|
@Drvi, I think the JET failures are unrelated? Would you mind taking a look? Otherwise, I think this is ready to merge and tag. |
Drvi
reviewed
Dec 14, 2022
nickrobinson251
approved these changes
Dec 14, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the switch to making Char non-greedy in the 2.5 release, I failed to account for the fact that the parsed Char may in fact be the delimiter provided, in which case we want to match the delim instead of treating it as a successfully parsed Char (Char is greedy in this way like Strings).
Luckily we can still do this pretty efficiently by checking our parsed Char against the delimiter, if there is one.