Fix a few corner cases of new Number parsing #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we encounter a decimal point, ensure we treat the `Number` as float instead of integer. For the case where we were _almost_ overflowing, we eagerly widen, but if we don't actually overflow, we want to "unwiden" back to the next lowest integer type. Also fix a few String parsing cases. At some point, we'll make parsing from a string more first-class, but for now, it works when calling the Parsers.parsenumber directly.
Codecov ReportBase: 86.72% // Head: 86.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 86.72% 86.74% +0.01%
==========================================
Files 9 9
Lines 1695 1705 +10
==========================================
+ Hits 1470 1479 +9
- Misses 225 226 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we encounter a decimal point, ensure we treat the
Numberas float instead of integer. For the case where we were almost overflowing, we eagerly widen, but if we don't actually overflow, we want to "unwiden" back to the next lowest integer type. Also fix a few String parsing cases.At some point, we'll make parsing from a string more first-class, but for now, it works when calling the Parsers.parsenumber directly.