Fix a error handling in UUID parser #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 87.39% 87.58% +0.18%
==========================================
Files 10 10
Lines 1856 1860 +4
==========================================
+ Hits 1622 1629 +7
+ Misses 234 231 -3
☔ View full report in Codecov by Sentry. |
nickrobinson251
approved these changes
May 16, 2023
| @@ -176,9 +177,12 @@ end | |||
| @noinline function _backtrack_error(source, pos, len, code, segment_len, hi, lo, pl) | |||
| pos -= segment_len # Backtrack to the start of the invalid hex | |||
| fastseek!(source, pos - 1) | |||
| while _HEX_LUT[peekbyte(source, pos) + 0x01] != 0xFFFF | |||
| b = peekbyte(source, pos) | |||
There was a problem hiding this comment.
should we check pos is valid here?
maybe a couple lines up add an @assert 1 <= pos <= len(is that right?)
There was a problem hiding this comment.
pos should always be valid here -- we only use _backtrack_error once we check the length would fit a UUID value and then we iterate in fixed sized steps (segment_len).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking
pos <= lenat the wrong place forUUIDs which have an insufficient length which lead to a bounds error when we were trying to skip over the malformed bytes. In tests we now also actually shrink thesource, not just thelenargument, which covers this error.Fixes #166