Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase accuracy of parsing subnormal floats #92

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Oct 14, 2021

Fixes #83. Previously, we eagerly bailed for small enough exponents when
parsing. Instead, we can take a slightly slower path by falling back on
BigInt/BigFloat for however small the exponent is to do the correct
scaling.

Fixes #83. Previously, we eagerly bailed for small enough exponents when
parsing. Instead, we can take a slightly slower path by falling back on
BigInt/BigFloat for however small the exponent is to do the correct
scaling.
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #92 (2750564) into main (f1c4530) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   87.56%   87.52%   -0.04%     
==========================================
  Files           9        9              
  Lines        2267     2269       +2     
==========================================
+ Hits         1985     1986       +1     
- Misses        282      283       +1     
Impacted Files Coverage Δ
src/floats.jl 92.78% <100.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c4530...2750564. Read the comment docs.

@quinnj quinnj merged commit a93ddf1 into main Oct 14, 2021
@quinnj quinnj deleted the jq/subnormals branch October 14, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing subnormal float with too many sig figs returns zero, even if it is larger than smallest subnormal
1 participant