Add macro for subtypes lowering with additional subtypekey field
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
May 22, 2023
quinnj
approved these changes
May 22, 2023
|
Ah, looks like we have some CI failures; mind taking a look @sairus7? |
|
Now it should be working. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 74.48% 75.31% +0.82%
==========================================
Files 2 2
Lines 388 401 +13
==========================================
+ Hits 289 302 +13
Misses 99 99
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this API covers all cases, maybe some other key types should be added (now its only Symbol).
closes #93 and quinnj/JSON3.jl#12