Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define StructType for Some as CustomStruct #45

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Define StructType for Some as CustomStruct #45

merged 2 commits into from
Apr 14, 2021

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Apr 14, 2021

Brought up in quinnj/JSON3.jl#143. This is
basically the exact use-case for CustomStruct.

Brought up in quinnj/JSON3.jl#143. This is
basically the exact use-case for `CustomStruct`.
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #45 (618dfff) into main (6a2d072) will decrease coverage by 0.23%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   69.48%   69.25%   -0.24%     
==========================================
  Files           1        1              
  Lines         331      335       +4     
==========================================
+ Hits          230      232       +2     
- Misses        101      103       +2     
Impacted Files Coverage Δ
src/StructTypes.jl 69.25% <33.33%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2d072...618dfff. Read the comment docs.

@quinnj quinnj merged commit 34fae89 into main Apr 14, 2021
@quinnj quinnj deleted the jq/some branch April 14, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant