Skip to content

Commit

Permalink
Recommend defining materializer(::Type{<:MyType}) (#282)
Browse files Browse the repository at this point in the history
For parametric types, defining `materializer(::Type{MyType})` doesn't work,
and this can be hard to catch.
  • Loading branch information
nalimilan committed May 19, 2022
1 parent 138c5be commit 60c080c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Tables.jl
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ default materializer is `Tables.columntable`, which converts any table input int
of `Vector`s.
It is recommended that for users implementing `MyType`, they define only
`materializer(::Type{MyType})`. `materializer(::MyType)` will then automatically delegate to
`materializer(::Type{<:MyType})`. `materializer(::MyType)` will then automatically delegate to
this method.
"""
function materializer end
Expand Down

0 comments on commit 60c080c

Please sign in to comment.