Implement DataAPI #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
May 9, 2019
| """ | ||
| Tables.allocatecolumn(::Type{T}, len) => returns a column type (usually AbstractVector) w/ size to hold `len` elements | ||
|
|
||
| Custom column types can override with an appropriate "scalar" element type that should dispatch to their column allocator. | ||
| """ | ||
| allocatecolumn(T, len) = Vector{T}(undef, len) | ||
| allocatecolumn(T, len) = DataAPI.defaultarray(T, 1)(undef, len) |
There was a problem hiding this comment.
Should defaultarray replace allocatecolumn at some point?
There was a problem hiding this comment.
they're slightly different; defaultarray just returns the array type for a given scalar type; allocatecolumn is for actually creating a column. We can probably just replace uses of allocatecolumn with defaultarray(T)(undef, len)
There was a problem hiding this comment.
Yes, that's what I had in mind.
src/tofromdatavalues.jl
Outdated
|
|
||
| Base.@pure function nondatavaluetype(::Type{NT}) where {NT <: NamedTuple{names}} where {names} | ||
| TT = Tuple{Any[ nondatavaluetype(fieldtype(NT, i)) for i = 1:fieldcount(NT) ]...} | ||
| DataAPI.nondatavaluetype(::Type{T}) where {T} = T |
There was a problem hiding this comment.
I know that this function is documented to be owned by Tables.jl, but given how simple this fallback definition is, why not put it in DataAPI instead? That would be simpler for everybody.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.