Fix printing of YAXArrays as DD subtype. #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultJudge resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Pull Request Test Coverage Report for Build 5462451119
💛 - Coveralls |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 58.60% 57.62% -0.98%
==========================================
Files 12 12
Lines 1744 1744
==========================================
- Hits 1022 1005 -17
- Misses 722 739 +17
☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 5464102804
💛 - Coveralls |
|
I also fixed the printing of the datasets so that they look like this now: julia> gcmip
YAXArray Dataset
Shared Axes:
()
Variables:
height,
tas
with dimensions:
Dim{:lon} Sampled{Float64} 0.0:0.9375:359.0625 ForwardOrdered Regular Points,
Dim{:lat} Sampled{Float64} Float64[-89.28422753251364, -88.35700351866494, …, 88.35700351866494, 89.28422753251364] ForwardOrdered Irregular Points,
Ti Sampled{DateTime} DateTime[2015-01-01T03:00:00, …, 2101-01-01T00:00:00] ForwardOrdered Irregular Points
Properties: Dict{String, Any}("initialization_index" => 1, "realm" => "atmos", "variable_id" => "tas", "external_variables" => "areacella", "branch_time_in_child" => 60265.0, "data_specs_version" => "01.00.30", "history" => "2019-07-21T06:26:13Z ; CMOR rewrote data to be consistent with CMIP6, CF-1.7 CMIP-6.2 and CF standards.", "forcing_index" => 1, "parent_variant_label" => "r1i1p1f1", "table_id" => "3hr"…)
julia> g
YAXArray Dataset
Shared Axes:
Dim{:lon} Sampled{Float64} -179.875:0.25:179.875 ForwardOrdered Regular Points,
Dim{:lat} Sampled{Float64} -89.875:0.25:89.875 ForwardOrdered Regular Points,
Ti Sampled{DateTime} DateTime[1979-01-05T00:00:00, …, 2021-12-31T00:00:00] ForwardOrdered Irregular Points
Variables:
sensible_heat, potential_evaporation, evaporation, root_moisture, radiation_era5, sif_rtsif, open_water_evaporation, nbar_swir1, latent_energy, max_air_temperature_2m, nbar_blue, cth, nirv, aerosol_optical_thickness_550, ctt, air_temperature_2m, nbar_swir3, nbar_red, evaporative_stress, precipitation_era5, nbar_green, terrestrial_ecosystem_respiration, gross_primary_productivity, ndvi, bare_soil_evaporation, nbar_swir2, sif_gosif, sif_gome2_jj, net_radiation, cot, kndvi, sif_gome2_pk, evaporation_era5, transpiration, surface_moisture, nbar_nir, interception_loss, min_air_temperature_2m, sm, burnt_area, net_ecosystem_exchange, snow_sublimation,
Properties: Dict{String, Any}("time_coverage_end" => "2021-12-31T00:00:00.000000000", "acknowledgment" => "All ESDC data providers are acknowledged inside each variable", "time_period_reported_day" => 5.0, "geospatial_lat_resolution" => 0.25, "time_coverage_start" => "1979-01-05T00:00:00.000000000", "id" => "esdc-8d-0.25deg-256x128x128-3.0.1", "publisher_url" => "https://www.earthsystemdatalab.net/", "date_modified" => "2022-11-25 23:13:03.350030", "geospatial_lat_min" => -89.875, "creator_url" => Any["https://www.uni-leipzig.de/", "https://www.brockmann-consult.de/"]…)
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
|
Great! Is this ready to be merged? |
|
Yes. The only thing is, that now all variables are in one line and we should somehow insert some linebreaks, but then we would have to change the whole printing logic. For now this should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the printing of the YAXArrays.
A YAXArray is now printed using the DimensionalData show machinery with a custom
show_aftermethod, so that we don't print the underlying array, because that might induce a huge latency when working with external data.The printing looks now like that: