Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide PDF artifact in PR #322

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Provide PDF artifact in PR #322

merged 2 commits into from
Nov 25, 2023

Conversation

rikhuijzer
Copy link
Member

Fixes #321.

I'm still debugging so feel free to unsubscribe.

@rikhuijzer rikhuijzer added the ci label Nov 25, 2023
@github-actions GitHub Actions
Copy link
Contributor

The PDF was created and uploaded as an artifact.

@storopoli
Copy link
Collaborator

Yak shaving. I think that the feature is correctly implemented and it works.
Only that the PDF is not building!

@github-actions GitHub Actions
Copy link
Contributor

The PDF was created and uploaded as an artifact.
You can find it on the GitHub Actions Summary page for the GitHub Actions Runs in this PR.

storopoli
storopoli approved these changes Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works!

@rikhuijzer rikhuijzer marked this pull request as ready for review November 25, 2023 11:03
@rikhuijzer rikhuijzer merged commit e9f249c into main Nov 25, 2023
2 checks passed
@rikhuijzer rikhuijzer deleted the rh/pdf-artifact branch November 25, 2023 11:03
@rikhuijzer rikhuijzer restored the rh/pdf-artifact branch November 25, 2023 11:03
@rikhuijzer rikhuijzer deleted the rh/pdf-artifact branch November 25, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storopoli storopoli storopoli approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Upload PDF as the CI Artifact
2 participants
@rikhuijzer @storopoli