Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypedSyntax has wrong compat bounds #463

Closed
Zentrik opened this issue Jun 3, 2023 · 1 comment · Fixed by #464
Closed

TypedSyntax has wrong compat bounds #463

Zentrik opened this issue Jun 3, 2023 · 1 comment · Fixed by #464

Comments

@Zentrik
Copy link
Collaborator

Zentrik commented Jun 3, 2023

The warn throws an error in Julia 1.1 (ERROR: LoadError: LoadError: syntax: invalid keyword argument syntax "warn"), I assume this syntax was not supported then.

function tsn_and_mappings(m::Method, src::CodeInfo, @nospecialize(rt); warn::Bool=true, strip_macros::Bool=false, kwargs...)

@timholy
Copy link
Member

timholy commented Jun 4, 2023

Thanks for reporting this. It looks like there's no version that supports 1.0. #464 should establish more reasonable bounds for future releases (and adds CI testing for just TypedSyntax on Julia 1.6), but there's a question of what to do about old bounds. I'd be inclined to submit a PR to General that makes it uninstallable on old Julia versions, but I am not sure if that's even allowed.

timholy added a commit that referenced this issue Jun 5, 2023
timholy added a commit to JuliaRegistries/General that referenced this issue Jun 5, 2023
In response to JuliaDebug/Cthulhu.jl#463,
this retrospectively requires Julia 1.6 or higher.
timholy added a commit to JuliaRegistries/General that referenced this issue Jun 15, 2023
In response to JuliaDebug/Cthulhu.jl#463,
this retrospectively requires Julia 1.6 or higher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants